Add BitArray HasAllSet, HasAnySet and PopCount - #587
Merged
Merged
Conversation
* HasAllSet() and HasAnySet(), added in net8 * PopCount(), added in net11 BitArray had no polyfills at all, so this adds the section. HasAllSet returns true for an empty BitArray, matching net11, since the condition is vacuous. Tests cover lengths either side of a 32 bit word boundary, because the unused high bits of the last word must not be counted.
This was referenced Sep 10, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the three
BitArraybit-population members:HasAllSet()andHasAnySet(), added in net8PopCount(), added in net11BitArrayhad no polyfills at all, so this adds the section. API count 1052 to 1055.Semantics
Checked against net11 rather than assumed:
HasAllSet()HasAnySet()PopCount()The one that could catch an implementation out is
HasAllSet()on an emptyBitArray, which istruebecause the condition is vacuous.The tests parameterise over lengths of 31, 32, 33, 64 and 100, since
BitArraystores bits in anint[]and the unused high bits of the last word must not be counted. Each case is also checked with the final bit cleared.The BCL implementations work a word at a time and these are bit at a time, but both are linear in the length, so no
//Note:was added.Verification
Consumebuilds clean in Debug across all 22 target frameworks.PublicTests,EmbeddedTests,UnsafeTests,NoRefsTestsandNoExtrasTests.HasAllSetandHasAnySetand the polyfill forPopCount, against the same assertions.